Skip to content

Convert utils test to pytest styled tests #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Nov 4, 2020

Description of the Change

Added generic models as by example of DRF. Those are not example models as before but generic in representing different constellations possible with Django models.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc
Copy link
Member Author

sliverc commented Nov 4, 2020

Currently marked as draft as #855 needs to be merged first and this rebased.

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #856 (258e825) into master (69a720a) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
- Coverage   97.90%   97.74%   -0.17%     
==========================================
  Files          63       60       -3     
  Lines        3489     3319     -170     
==========================================
- Hits         3416     3244     -172     
- Misses         73       75       +2     
Impacted Files Coverage Δ
rest_framework_json_api/settings.py 92.00% <0.00%> (-8.00%) ⬇️
example/models.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69a720a...258e825. Read the comment docs.

Added generic models as by example of DRF. Those are not example
models as before but generic in representing different constellations
possible with Django models.
@sliverc sliverc marked this pull request as ready for review November 9, 2020 20:30
@sliverc sliverc requested a review from n2ygk November 9, 2020 20:30
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for breaking these tests down into bite-sized PRs.

@n2ygk n2ygk merged commit c392a43 into django-json-api:master Nov 10, 2020
@sliverc sliverc deleted the test_utils branch December 28, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants